Skip to content

hoisted loop constants/increments and made opts to resolve_entry_points #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateoconlechuga merged 1 commit into from
Feb 5, 2026
Merged

hoisted loop constants/increments and made opts to resolve_entry_points #701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions src/libload/libload.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,15 +301,15 @@ optional_lib_clear:
ld de, 0
ld (hl), e ; mark optional library as not found
pop hl
inc hl ; skip version byte
ld a, JP_OPCODE
; inc hl ; skip version byte
.loop:
ld a, (hl)
cp a, JP_OPCODE ; jp byte ($C3)
inc hl
cp a, (hl) ; jp byte ($C3)
jr nz, .done
inc hl
ld (hl), de ; make the vector zero
inc hl
inc hl
inc hl ; move to next jump
jr .loop

Expand Down Expand Up @@ -445,12 +445,12 @@ enqueue_all_deps: ; we don't need to store anything if we are here
ex de, hl
.skip:
move_string_to_end
inc hl ; move to start of dependency jump table
ld a, JP_OPCODE
; inc hl ; move to start of dependency jump table
.next:
ld a, (hl)
cp a, JP_OPCODE
jr nz, .loop
inc hl
cp a, (hl) ; jp byte ($C3)
jr nz, .loop
inc hl
inc hl
inc hl ; jp address
Expand All @@ -464,15 +464,15 @@ enqueue_all_deps: ; we don't need to store anything if we are here
resolve_entry_points_enqueued:

ld hl, (jump_tbl_ptr) ; hl->start of function jump table
ld bc, 3
ld a, JP_OPCODE
.loop:
ld a, (hl)
cp a, JP_OPCODE ; jp byte ($C3)
cp a, (hl) ; jp byte ($C3)
jr nz, .done
inc hl ; bypass jp byte ($C3)
push hl
ld hl, (hl) ; offset in vector table (0, 3, 6, etc.)
ld bc, 3
call ti._idivs ; originally the offset was just added because vectors were stored in three bytes, now it is just 2 to save space
call ti._idivu ; originally the offset was just added because vectors were stored in three bytes, now it is just 2 to save space
add hl, hl ; (offset/3) * 2
ld de, (vector_tbl_ptr) ; hl->start of vector table
add hl, de ; hl->correct vector entry
Expand All @@ -482,9 +482,7 @@ resolve_entry_points_enqueued:
ex de, hl ; de->function in ram
pop hl ; restore jump offset
ld (hl), de ; de=resolved address
inc hl
inc hl
inc hl ; move to next jump
add hl, bc ; move to next jump
jr .loop

.done: ; finished resolving entry points
Expand Down
Loading