From c2c4d916156f68b51b1bdb35076da143dc824c76 Mon Sep 17 00:00:00 2001
From: shanferns12 <sqf220@lehigh.edu>
Date: Wed, 14 Sep 2022 15:21:09 -0400
Subject: [PATCH] Update shannon.py

---
 tools/shannon.py | 26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/tools/shannon.py b/tools/shannon.py
index af07332..666238a 100644
--- a/tools/shannon.py
+++ b/tools/shannon.py
@@ -1,16 +1,23 @@
 import numpy as np
 import concore
 setpoint = 67.5
+Kp = 0.1
+Ki = 0.01
+Kd = 0.01
+dT = 0.1
+global Prev_Error, I
+Prev_Error = 0
+I = 0
 
 
-def bangbang_controller(ym):
-    amp = 0
-    if ym[0]>setpoint +2.5:
-        amp = 3
-    elif ym[0]<setpoint -2.5:
-        amp = 1
-	    
-     
+def  pid_controller(ym):
+    global Prev_Error, I
+    Error = setpoint- ym[0]
+    P = Error
+    I = I + Error*dT 
+    D = (Error - Prev_Error )/dT	
+    amp = Kp*P + Ki*I + Kd*D
+    Prev_Error = Error      
     ustar = np.array([amp,30])    
     return ustar
 
@@ -26,7 +33,8 @@ def bangbang_controller(ym):
         ym = concore.read(1,"ym",init_simtime_ym)
     ym = np.array(ym)
     
-    ustar = bangbang_controller(ym)
+    ustar =  pid_controller(ym)
     
     print(str(concore.simtime) + " u="+str(ustar) + "ym="+str(ym))
     concore.write(1,"u",list(ustar),delta=0)
+