Because Java uses virtual dispatch even during superclass construction, overriding + * {@code setValue} here also prevents the packet sends that happen inside the + * {@link ContainerTerminalStoragePart} constructor (e.g. from {@code setSelectedChannel}). + */ + private static ContainerTerminalStoragePart createSilentContainer(ServerPlayer player, PartTarget partTarget) { + return new ContainerTerminalStoragePart( + 1, player.getInventory(), partTarget, PartTypes.TERMINAL_STORAGE, + Optional.empty(), new TerminalStorageState(() -> {})) { + @Override + public void setValue(int valueId, CompoundTag value) { + // Suppress cyclopscore:value_notify packet sends in the game test environment. + } + }; + } + + /** + * Creates a mock server player in the level. + * + *
This replicates {@link GameTestHelper#makeMockServerPlayerInLevel()} but catches the
+ * {@link UnsupportedOperationException} that IntegratedDynamics throws when it tries to send
+ * an {@code integrateddynamics:all_labels} packet during the player login event, because the
+ * game test environment's embedded channel does not have custom NeoForge channels negotiated.
+ * By the time that exception fires, {@code placeNewPlayer} has already fully set up the player:
+ * {@link ServerPlayer#connection} is assigned, {@link ServerPlayer#initInventoryMenu()} has
+ * been called (enabling the {@code containerListener} that fires advancement criteria), and the
+ * player has been added to both the world and the player list.
+ */
+ private static ServerPlayer createMockServerPlayer(GameTestHelper helper) {
+ CommonListenerCookie cookie = CommonListenerCookie.createInitial(
+ new GameProfile(UUID.randomUUID(), "test-mock-player"), false);
+ ServerPlayer player = new ServerPlayer(
+ helper.getLevel().getServer(), helper.getLevel(), cookie.gameProfile(), cookie.clientInformation()) {
+ @Override
+ public boolean isSpectator() {
+ return false;
+ }
+
+ @Override
+ public boolean isCreative() {
+ return true;
+ }
+ };
+ Connection connection = new Connection(PacketFlow.SERVERBOUND);
+ new EmbeddedChannel(connection);
+ try {
+ helper.getLevel().getServer().getPlayerList().placeNewPlayer(connection, player, cookie);
+ } catch (Exception ignored) {
+ // IntegratedDynamics sends a custom packet (integrateddynamics:all_labels) during the
+ // PlayerLoggedInEvent that fails in game tests because no channel negotiation occurs.
+ // Everything needed for advancement tests is set up before that event fires.
+ }
+ return player;
+ }
+
+ /**
+ * Tests the root advancement, triggered by having a part_display_panel in the inventory.
+ */
+ @GameTest(template = "empty", templateNamespace = "cyclopscore")
+ public void testAdvancementRoot(GameTestHelper helper) {
+ ServerPlayer player = createMockServerPlayer(helper);
+ // Give player a part_display_panel to trigger the inventory_changed criterion
+ player.getInventory().setItem(0, new ItemStack(
+ BuiltInRegistries.ITEM.get(ResourceLocation.parse("integrateddynamics:part_display_panel"))));
+ player.inventoryMenu.broadcastChanges();
+ helper.succeedWhen(() -> helper.assertTrue(
+ hasAdvancementUnlocked(player, "integratedterminals:root"),
+ "root advancement not unlocked"));
+ }
+
+ /**
+ * Tests the menril_glass advancement, triggered by having menril_glass in the inventory.
+ */
+ @GameTest(template = "empty", templateNamespace = "cyclopscore")
+ public void testAdvancementMenrilGlass(GameTestHelper helper) {
+ ServerPlayer player = createMockServerPlayer(helper);
+ // Give player menril_glass to trigger the inventory_changed criterion
+ player.getInventory().setItem(0, new ItemStack(
+ BuiltInRegistries.ITEM.get(ResourceLocation.parse("integratedterminals:menril_glass"))));
+ player.inventoryMenu.broadcastChanges();
+ helper.succeedWhen(() -> helper.assertTrue(
+ hasAdvancementUnlocked(player, "integratedterminals:storage_terminal/menril_glass"),
+ "menril_glass advancement not unlocked"));
+ }
+
+ /**
+ * Tests the craft_storage_terminal advancement, triggered by crafting a part_terminal_storage.
+ */
+ @GameTest(template = "empty", templateNamespace = "cyclopscore")
+ public void testAdvancementCraftStorageTerminal(GameTestHelper helper) {
+ ServerPlayer player = createMockServerPlayer(helper);
+ // Simulate crafting a part_terminal_storage by posting the ItemCraftedEvent
+ ItemStack craftedItem = new ItemStack(
+ BuiltInRegistries.ITEM.get(ResourceLocation.parse("integratedterminals:part_terminal_storage")));
+ NeoForge.EVENT_BUS.post(new PlayerEvent.ItemCraftedEvent(player, craftedItem, new SimpleContainer(9)));
+ helper.succeedWhen(() -> helper.assertTrue(
+ hasAdvancementUnlocked(player, "integratedterminals:storage_terminal/craft_storage_terminal"),
+ "craft_storage_terminal advancement not unlocked"));
+ }
+
+ /**
+ * Tests the gui_storage_terminal advancement, triggered by opening the terminal storage GUI.
+ */
+ @GameTest(template = "empty", templateNamespace = "cyclopscore")
+ public void testAdvancementGuiStorageTerminal(GameTestHelper helper) {
+ BlockPos pos = new BlockPos(1, 2, 1);
+ ServerPlayer player = createMockServerPlayer(helper);
+
+ // Place cable block and add terminal_storage part
+ helper.setBlock(pos, RegistryEntries.BLOCK_CABLE.value());
+ NetworkHelpers.initNetwork(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH);
+ PartHelpers.addPart(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH,
+ PartTypes.TERMINAL_STORAGE, new ItemStack(PartTypes.TERMINAL_STORAGE.getItem()));
+
+ // Create the container directly (not via openMenu, which triggers custom-packet sends that
+ // fail in the game test environment's embedded channel). Fire PlayerContainerEvent.Open to
+ // trigger the cyclopscore:container_gui_open advancement criterion.
+ PartPos partPos = PartPos.of(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH);
+ PartTarget partTarget = PartTarget.fromCenter(partPos);
+ ContainerTerminalStoragePart container = createSilentContainer(player, partTarget);
+ NeoForge.EVENT_BUS.post(new PlayerContainerEvent.Open(player, container));
+
+ helper.succeedWhen(() -> helper.assertTrue(
+ hasAdvancementUnlocked(player, "integratedterminals:storage_terminal/gui_storage_terminal"),
+ "gui_storage_terminal advancement not unlocked"));
+ }
+
+ /**
+ * Tests the filter_enchantable advancement, triggered by setting an itemstack_enchantable operator variable
+ * in the terminal storage filter slots.
+ */
+ @GameTest(template = "empty", templateNamespace = "cyclopscore")
+ public void testAdvancementFilterEnchantable(GameTestHelper helper) {
+ BlockPos pos = new BlockPos(1, 2, 1);
+ ServerPlayer player = createMockServerPlayer(helper);
+
+ // Place cable block and add terminal_storage part
+ helper.setBlock(pos, RegistryEntries.BLOCK_CABLE.value());
+ NetworkHelpers.initNetwork(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH);
+ PartHelpers.addPart(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH,
+ PartTypes.TERMINAL_STORAGE, new ItemStack(PartTypes.TERMINAL_STORAGE.getItem()));
+
+ // Create the container directly (not via openMenu, which triggers custom-packet sends that
+ // fail in the game test environment's embedded channel).
+ PartPos partPos = PartPos.of(helper.getLevel(), helper.absolutePos(pos), Direction.NORTH);
+ PartTarget partTarget = PartTarget.fromCenter(partPos);
+ ContainerTerminalStoragePart container = createSilentContainer(player, partTarget);
+
+ // Directly trigger the advancement by calling onVariableContentsUpdated with a mock
+ // IVariable that returns the itemstack_enchantable operator value. This simulates what
+ // happens when a valid operator variable is placed in the filter slot and the network
+ // evaluates it — bypassing the InventoryVariableEvaluator which returns null in game
+ // tests because the variable item is not registered in the network's variable store.
+ INetwork network = container.getNetwork().get();
+ ValueTypeOperator.ValueOperator operatorValue =
+ ValueTypeOperator.ValueOperator.of(Operators.OBJECT_ITEMSTACK_ISENCHANTABLE);
+ IVariable