Skip to content

Fix: Add destructor to free strmap memory in sql plugin #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andezion wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −0
Open

Fix: Add destructor to free strmap memory in sql plugin #8827

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d67efa4
fix: add destructor to free strmap memory in sql plugin
Andezion Jan 7, 2026
0c2e2f2
added missing changelog
Andezion Jan 26, 2026
820e7db
added missing changelog
Andezion Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugins/sql.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ struct sql {
u64 next_rowid;
};

static void destroy_sql(struct sql *sql)
{
strmap_clear(&sql->tablemap);
}

static struct sql *sql_of(struct plugin *plugin)
{
return plugin_get_data(plugin, struct sql);
Expand Down Expand Up @@ -1986,6 +1991,7 @@ int main(int argc, char *argv[])
}

sql = tal(NULL, struct sql);
tal_add_destructor(sql, destroy_sql);
sql->dbfilename = NULL;
sql->gosstore_fd = -1;
sql->gosstore_nodes_off = sql->gosstore_channels_off = 0;
Expand Down
Loading