From 44b9767a3c00ad103bbd6b07ab3b35f0fa39967a Mon Sep 17 00:00:00 2001 From: AJ Ancheta <7781450+ancheetah@users.noreply.github.com> Date: Fri, 13 Feb 2026 19:02:46 -0500 Subject: [PATCH] fix(davinci-client): fix updater for device registration collector --- .changeset/good-buckets-raise.md | 5 +++++ packages/davinci-client/src/lib/node.reducer.ts | 10 +++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 .changeset/good-buckets-raise.md diff --git a/.changeset/good-buckets-raise.md b/.changeset/good-buckets-raise.md new file mode 100644 index 0000000000..e17fdd02d6 --- /dev/null +++ b/.changeset/good-buckets-raise.md @@ -0,0 +1,5 @@ +--- +'@forgerock/davinci-client': patch +--- + +Fix device registration collector updater diff --git a/packages/davinci-client/src/lib/node.reducer.ts b/packages/davinci-client/src/lib/node.reducer.ts index 63bf2e36ec..850b291395 100644 --- a/packages/davinci-client/src/lib/node.reducer.ts +++ b/packages/davinci-client/src/lib/node.reducer.ts @@ -265,12 +265,16 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build id: option.value, value: option.content, }; + return; } if (collector.type === 'DeviceRegistrationCollector') { if (typeof action.payload.id !== 'string') { throw new Error('Index argument must be a string'); } + if (typeof action.payload.value !== 'string') { + throw new Error('Value argument must be a string'); + } // Iterate through the options object and find option to update const option = collector.output.options.find( @@ -281,7 +285,8 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build throw new Error('No option found matching value to update'); } - collector.input.value = option.type; + collector.input.value = action.payload.value; + return; } if (collector.type === 'PhoneNumberCollector') { @@ -295,6 +300,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build throw new Error('Value argument must contain a phoneNumber and countryCode property'); } collector.input.value = action.payload.value; + return; } if (collector.type === 'FidoRegistrationCollector') { @@ -308,6 +314,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build throw new Error('Value argument must contain an attestationValue property'); } collector.input.value = action.payload.value; + return; } if (collector.type === 'FidoAuthenticationCollector') { @@ -321,6 +328,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build throw new Error('Value argument must contain an assertionValue property'); } collector.input.value = action.payload.value; + return; } }); });