From c08ca8da479a5af3e23e7115a11ad8cbcd4acb05 Mon Sep 17 00:00:00 2001 From: jheim2 Date: Fri, 27 Feb 2026 13:48:15 +0100 Subject: [PATCH 1/2] Ensure $login is never null when calling ilObjUser::_lookupId() (use ?? '') Prevent cronjob failure when $login is null --- .../Course/class.ilECSCmsCourseMemberCommandQueueHandler.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php b/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php index 2cc0fb39dce2..1fcd7c156eb5 100755 --- a/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php +++ b/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php @@ -345,7 +345,7 @@ protected function refreshAssignmentStatus(object $course_member, int $obj_id, ? } } } else { - if ($il_usr_id = ilObjUser::_lookupId($login)) { + if ($il_usr_id = ilObjUser::_lookupId($login ?? "")) { // user exists => assign to course/group if ($role) { // Assign user @@ -364,7 +364,7 @@ protected function refreshAssignmentStatus(object $course_member, int $obj_id, ? ); } // Assign to role - if ($role && $il_usr_id = ilObjUser::_lookupId($login)) { + if ($role && $il_usr_id = ilObjUser::_lookupId($login ? "")) { $this->log->info('Assigning new role to existing user ' . $person_id . ' ' . 'to ' . ilObject::_lookupTitle($obj_id) . ' using role: ' . $role); $part->add($il_usr_id, $role); $part->sendNotification(ilCourseMembershipMailNotification::TYPE_ADMISSION_MEMBER, $il_usr_id); From 3f0448a0a3e67e6d0397dfb90266735a2c399a18 Mon Sep 17 00:00:00 2001 From: jheim2 Date: Fri, 27 Feb 2026 20:54:41 +0100 Subject: [PATCH 2/2] Fix typo: use ?? instead of ? --- .../Course/class.ilECSCmsCourseMemberCommandQueueHandler.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php b/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php index 1fcd7c156eb5..72b32c69e786 100755 --- a/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php +++ b/components/ILIAS/WebServices/ECS/classes/Course/class.ilECSCmsCourseMemberCommandQueueHandler.php @@ -364,7 +364,7 @@ protected function refreshAssignmentStatus(object $course_member, int $obj_id, ? ); } // Assign to role - if ($role && $il_usr_id = ilObjUser::_lookupId($login ? "")) { + if ($role && $il_usr_id = ilObjUser::_lookupId($login ?? "")) { $this->log->info('Assigning new role to existing user ' . $person_id . ' ' . 'to ' . ilObject::_lookupTitle($obj_id) . ' using role: ' . $role); $part->add($il_usr_id, $role); $part->sendNotification(ilCourseMembershipMailNotification::TYPE_ADMISSION_MEMBER, $il_usr_id);