When in HOLD, RELEASED event is no longer sent

[nokolade]

For a BLE mouse the HOLD feature is not needed.
Instead, the PRESSED and RELEASED events should be passed to as BleMouse.press() and .release() respectively.

When in HOLD, RELEASED event is no longer sent.

I see following solutions:

1. RELEASED event is sent irregardless if HOLD is detected -> would trigger two events :-(
2. document that holdThreshold can be set to 0 and register for PRESSED and HOLD_RELEASED -> should work, but naming is not intuitive
3. set holdThreshold to MAX_INT -> not clean but should be safe in practice
4. register for both RELEASED and HOLD_RELEASED -> code duplication
5. change library to holdThreshold can be set to 0 (or -1) to allow disabling hold completely -> seems cleanest

I'll go for 3 for now.

[IPdotSetAF]

please keep AI slop in your own repos.

[nokolade]

Hi Mahdi,
Thank you @IPdotSetAF for your fast reaction.
Every char was typed by hand. May I take it as a compliment?
My discussion was to improve the project and the docu - and yes, I could commit myself or fork, I know.

[IPdotSetAF]

oh, sorry for the misunderstanding @nokolade , my bad.

• by design, Its guaranteed that only one of the RELEASE or HOLD_RELEASE functions is called at a time, so there will be no event duplication in any possible usecase/scenario.

• i do agree that the event names can be improved.

• documents can always improve , would be happy to see your revision.

• i suggest the 4th option you mentioned (that's how i use the lib as well), and there is no code duplication if you pass in a function instead of a lambda.