From a4b21491804f83d8d5e5ce7a604d15a928ef487b Mon Sep 17 00:00:00 2001 From: Devguru Date: Fri, 27 Feb 2026 20:05:51 +0530 Subject: [PATCH] fix: Remove dead if-None check from get_bids_metadata and fix impossible test mocks --- package/src/pyaslreport/main.py | 3 --- package/src/pyaslreport/tests/test_package.py | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/package/src/pyaslreport/main.py b/package/src/pyaslreport/main.py index 553e7e5e..4af73ad9 100644 --- a/package/src/pyaslreport/main.py +++ b/package/src/pyaslreport/main.py @@ -31,9 +31,6 @@ def get_bids_metadata(data): dicom_header = get_dicom_header(dicom_dir) sequence = get_sequence(modality, dicom_header) - if sequence is None: - raise ValueError(f"No matching sequence found for modality '{modality}' with the provided DICOM header") - return sequence.extract_bids_metadata() diff --git a/package/src/pyaslreport/tests/test_package.py b/package/src/pyaslreport/tests/test_package.py index fda43d33..9f5d315f 100644 --- a/package/src/pyaslreport/tests/test_package.py +++ b/package/src/pyaslreport/tests/test_package.py @@ -24,15 +24,15 @@ def test_get_bids_metadata_no_sequence(): data = {"modality": "asl", "dicom_dir": "/fake/dir"} fake_header = MagicMock() with patch("pyaslreport.main.get_dicom_header", return_value=fake_header), \ - patch("pyaslreport.main.get_sequence", return_value=None): + patch("pyaslreport.main.get_sequence", side_effect=ValueError("No ASL sequence class found")): with pytest.raises(ValueError) as exc: get_bids_metadata(data) - assert "No matching sequence found" in str(exc.value) + assert "No ASL sequence class found" in str(exc.value) def test_get_bids_metadata_invalid_modality(): data = {"modality": None, "dicom_dir": "/fake/dir"} fake_header = MagicMock() with patch("pyaslreport.main.get_dicom_header", return_value=fake_header), \ - patch("pyaslreport.main.get_sequence", return_value=None): + patch("pyaslreport.main.get_sequence", side_effect=ValueError("Unsupported modality")): with pytest.raises(ValueError): get_bids_metadata(data) \ No newline at end of file