From 8ea18fbd96cfb8d50bbb7ef99f6c941962923b7f Mon Sep 17 00:00:00 2001 From: Jayensee <118075978+Jayensee@users.noreply.github.com> Date: Sun, 1 Feb 2026 17:14:16 +0000 Subject: [PATCH 1/3] Change eff max hit to harmonic mean --- src/Modules/CalcDefence.lua | 15 +++++---------- src/Modules/Data.lua | 2 +- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/Modules/CalcDefence.lua b/src/Modules/CalcDefence.lua index 0c349cd1bc..7adacd0b6e 100644 --- a/src/Modules/CalcDefence.lua +++ b/src/Modules/CalcDefence.lua @@ -3246,18 +3246,13 @@ function calcs.buildDefenceEstimations(env, actor) end end - -- second minimum used for power calcs, as there are issues using average or minimum - local minimum = m_huge - local SecondMinimum = m_huge + -- harmonic mean used for power calcs (equivalent to the maximum hit when the hit is equally split between all damage types) + -- ideally there should be weights to account for the fact that damage types usually have different scales (phys hits are smaller than ele hits) + local reciprocalSum = 0 for _, damageType in ipairs(dmgTypeList) do - if output[damageType.."MaximumHitTaken"] < minimum then - SecondMinimum = minimum - minimum = output[damageType.."MaximumHitTaken"] - elseif output[damageType.."MaximumHitTaken"] < SecondMinimum then - SecondMinimum = output[damageType.."MaximumHitTaken"] - end + reciprocalSum = reciprocalSum + 1 / output[damageType .. "MaximumHitTaken"] end - output.SecondMinimalMaximumHitTaken = SecondMinimum + output.EffectiveMaximumHitTaken = 5 / reciprocalSum end -- effective health pool vs dots diff --git a/src/Modules/Data.lua b/src/Modules/Data.lua index be484e0c32..05537f2ec9 100644 --- a/src/Modules/Data.lua +++ b/src/Modules/Data.lua @@ -142,7 +142,7 @@ data.powerStatList = { { stat="SpellAvoidChance", label="Spell avoid chance" }, { stat="ProjectileAvoidChance", label="Projectile avoid chance" }, { stat="TotalEHP", label="Effective Hit Pool" }, - { stat="SecondMinimalMaximumHitTaken", label="Eff. Maximum Hit Taken" }, + { stat="EffectiveMaximumHitTaken", label="Eff. Maximum Hit Taken" }, { stat="PhysicalTakenHit", label="Taken Phys dmg", transform=function(value) return -value end }, { stat="LightningTakenHit", label="Taken Lightning dmg", transform=function(value) return -value end }, { stat="ColdTakenHit", label="Taken Cold dmg", transform=function(value) return -value end }, From d2907c73d2f6d0d5ef95abf49a35ac7b0cf37c38 Mon Sep 17 00:00:00 2001 From: Jayensee <118075978+Jayensee@users.noreply.github.com> Date: Sun, 1 Feb 2026 19:43:16 +0000 Subject: [PATCH 2/3] Add eff max hit to display stats --- src/Modules/BuildDisplayStats.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Modules/BuildDisplayStats.lua b/src/Modules/BuildDisplayStats.lua index 1b4061e5dc..c9b1c21135 100644 --- a/src/Modules/BuildDisplayStats.lua +++ b/src/Modules/BuildDisplayStats.lua @@ -108,6 +108,7 @@ local displayStats = { { stat = "ColdMaximumHitTaken", label = "Cold Max Hit", fmt = ".0f", color = colorCodes.COLD, compPercent = true, condFunc = function(v,o) return o.LightningMaximumHitTaken ~= o.ColdMaximumHitTaken or o.LightningMaximumHitTaken ~= o.FireMaximumHitTaken end }, { stat = "LightningMaximumHitTaken", label = "Lightning Max Hit", fmt = ".0f", color = colorCodes.LIGHTNING, compPercent = true, condFunc = function(v,o) return o.LightningMaximumHitTaken ~= o.ColdMaximumHitTaken or o.LightningMaximumHitTaken ~= o.FireMaximumHitTaken end }, { stat = "ChaosMaximumHitTaken", label = "Chaos Max Hit", fmt = ".0f", color = colorCodes.CHAOS, compPercent = true }, + { stat = "EffectiveMaximumHitTaken", label = "Effective Max Hit", fmt = ".0f", compPercent = true }, { }, { stat = "MainHand", childStat = "Accuracy", label = "MH Accuracy", fmt = "d", condFunc = function(v,o) return o.PreciseTechnique end, warnFunc = function(v,o) return v < o.Life and "You do not have enough Accuracy for Precise Technique" end, warnColor = true }, { stat = "OffHand", childStat = "Accuracy", label = "OH Accuracy", fmt = "d", condFunc = function(v,o) return o.PreciseTechnique end, warnFunc = function(v,o) return v < o.Life and "You do not have enough Accuracy for Precise Technique" end, warnColor = true }, From 057bce00e5e29dab005136dba393aa0ba533f2e8 Mon Sep 17 00:00:00 2001 From: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Date: Fri, 6 Feb 2026 16:37:50 +1100 Subject: [PATCH 3/3] Remove Effective max hit from sidebar This number will just confuse users and adding more items to the sidebar is something that we like to avoid, as it is already quite cluttered --- src/Modules/BuildDisplayStats.lua | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Modules/BuildDisplayStats.lua b/src/Modules/BuildDisplayStats.lua index c9b1c21135..b8463431fd 100644 --- a/src/Modules/BuildDisplayStats.lua +++ b/src/Modules/BuildDisplayStats.lua @@ -108,7 +108,6 @@ local displayStats = { { stat = "ColdMaximumHitTaken", label = "Cold Max Hit", fmt = ".0f", color = colorCodes.COLD, compPercent = true, condFunc = function(v,o) return o.LightningMaximumHitTaken ~= o.ColdMaximumHitTaken or o.LightningMaximumHitTaken ~= o.FireMaximumHitTaken end }, { stat = "LightningMaximumHitTaken", label = "Lightning Max Hit", fmt = ".0f", color = colorCodes.LIGHTNING, compPercent = true, condFunc = function(v,o) return o.LightningMaximumHitTaken ~= o.ColdMaximumHitTaken or o.LightningMaximumHitTaken ~= o.FireMaximumHitTaken end }, { stat = "ChaosMaximumHitTaken", label = "Chaos Max Hit", fmt = ".0f", color = colorCodes.CHAOS, compPercent = true }, - { stat = "EffectiveMaximumHitTaken", label = "Effective Max Hit", fmt = ".0f", compPercent = true }, { }, { stat = "MainHand", childStat = "Accuracy", label = "MH Accuracy", fmt = "d", condFunc = function(v,o) return o.PreciseTechnique end, warnFunc = function(v,o) return v < o.Life and "You do not have enough Accuracy for Precise Technique" end, warnColor = true }, { stat = "OffHand", childStat = "Accuracy", label = "OH Accuracy", fmt = "d", condFunc = function(v,o) return o.PreciseTechnique end, warnFunc = function(v,o) return v < o.Life and "You do not have enough Accuracy for Precise Technique" end, warnColor = true }, @@ -246,4 +245,4 @@ local extraSaveStats = { "ActiveMinionLimit", } -return displayStats, minionDisplayStats, extraSaveStats \ No newline at end of file +return displayStats, minionDisplayStats, extraSaveStats