From 6dbdce14e81c7a98df491ffcc6dc98e951337942 Mon Sep 17 00:00:00 2001 From: Pierre Yger Date: Fri, 16 Jan 2026 08:57:43 +0100 Subject: [PATCH 1/2] WIP --- .../metrics/quality/misc_metrics.py | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/src/spikeinterface/metrics/quality/misc_metrics.py b/src/spikeinterface/metrics/quality/misc_metrics.py index f985ea6e23..eac1b9e116 100644 --- a/src/spikeinterface/metrics/quality/misc_metrics.py +++ b/src/spikeinterface/metrics/quality/misc_metrics.py @@ -1491,21 +1491,8 @@ def slidingRP_violations( method = "numba" if HAVE_NUMBA else "numpy" - bin_size = max(int(bin_size_ms / 1000 * sorting.sampling_frequency), 1) - window_size = int(window_size_s * sorting.sampling_frequency) - - if method == "numpy": - from spikeinterface.postprocessing.correlograms import _compute_correlograms_numpy - - correlogram = _compute_correlograms_numpy(sorting, window_size, bin_size)[0, 0] - if method == "numba": - from spikeinterface.postprocessing.correlograms import _compute_correlograms_numba - - correlogram = _compute_correlograms_numba(sorting, window_size, bin_size)[0, 0] - - ## I dont get why this line is not giving exactly the same result as the correlogram function. I would question - # the choice of the bin_size above, but I am not the author of the code... - # correlogram = compute_correlograms(sorting, 2*window_size_s*1000, bin_size_ms, method=method)[0][0, 0] + from spikeinterface.postprocessing.correlograms import compute_correlograms + correlogram = compute_correlograms(sorting, 2*window_size_s*1000, bin_size_ms, method=method)[0][0, 0] correlogram_positive = correlogram[len(correlogram) // 2 :] conf_matrix = _compute_violations( From 62ab2922339e7373226d9d81340cb8d2ccc622cb Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 16 Jan 2026 08:06:24 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/spikeinterface/metrics/quality/misc_metrics.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/spikeinterface/metrics/quality/misc_metrics.py b/src/spikeinterface/metrics/quality/misc_metrics.py index eac1b9e116..6090ae423d 100644 --- a/src/spikeinterface/metrics/quality/misc_metrics.py +++ b/src/spikeinterface/metrics/quality/misc_metrics.py @@ -1492,7 +1492,8 @@ def slidingRP_violations( method = "numba" if HAVE_NUMBA else "numpy" from spikeinterface.postprocessing.correlograms import compute_correlograms - correlogram = compute_correlograms(sorting, 2*window_size_s*1000, bin_size_ms, method=method)[0][0, 0] + + correlogram = compute_correlograms(sorting, 2 * window_size_s * 1000, bin_size_ms, method=method)[0][0, 0] correlogram_positive = correlogram[len(correlogram) // 2 :] conf_matrix = _compute_violations(