Prepare Apollo Java 2.6.0-SNAPSHOT#133
Conversation
📝 WalkthroughWalkthroughThis PR updates the Apollo Java project version from 2.5.0 to 2.6.0-SNAPSHOT. It creates a new changelog file documenting the 2.5.0 release features, updates the main changelog with the new version, and modifies the milestone reference accordingly. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
============================================
+ Coverage 68.68% 71.01% +2.32%
- Complexity 1503 1634 +131
============================================
Files 212 224 +12
Lines 6396 6727 +331
Branches 647 679 +32
============================================
+ Hits 4393 4777 +384
+ Misses 1673 1600 -73
- Partials 330 350 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
changes/changes-2.5.0.md (1)
17-17: Non-descriptive link texthere(markdownlint MD059).
[here](...)is flagged by markdownlint as non-descriptive; however, this pattern is already used identically in the mainCHANGES.mdline 12, so it is a pre-existing project convention. Changing it here for consistency with the rest of the docs is an optional improvement.♻️ Optional: make link text descriptive
-All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/5?closed=1) +All issues and pull requests are [linked in milestone 5](https://github.com/apolloconfig/apollo-java/milestone/5?closed=1)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@changes/changes-2.5.0.md` at line 17, Replace the non-descriptive link text "here" in the line All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/5?closed=1) with a descriptive phrase to satisfy markdownlint MD059 (for example: "the milestone", "the closed milestone", or "this milestone") so the link reads All issues and pull requests are [the milestone](...) or similar; update changes/changes-2.5.0.md by changing only the link text while keeping the URL intact to maintain consistency with the project convention.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@changes/changes-2.5.0.md`:
- Line 9: Fix the typo in the release note bullet by replacing "APl" with "API"
in the string "* [Feature Provide a new open APl to return the organization
list](https://github.com/apolloconfig/apollo-java/pull/102)" so it reads
"Provide a new open API to return the organization list"; update the exact text
in changes-2.5.0.md where that bullet appears (look for the phrase "Provide a
new open APl to return the organization list").
---
Nitpick comments:
In `@changes/changes-2.5.0.md`:
- Line 17: Replace the non-descriptive link text "here" in the line All issues
and pull requests are
[here](https://github.com/apolloconfig/apollo-java/milestone/5?closed=1) with a
descriptive phrase to satisfy markdownlint MD059 (for example: "the milestone",
"the closed milestone", or "this milestone") so the link reads All issues and
pull requests are [the milestone](...) or similar; update
changes/changes-2.5.0.md by changing only the link text while keeping the URL
intact to maintain consistency with the project convention.
|
|
||
| ------------------ | ||
|
|
||
| * [Feature Provide a new open APl to return the organization list](https://github.com/apolloconfig/apollo-java/pull/102) |
There was a problem hiding this comment.
Typo: APl should be API.
The lowercase l in APl is a typo confirmed by static analysis.
✏️ Proposed fix
-* [Feature Provide a new open APl to return the organization list](https://github.com/apolloconfig/apollo-java/pull/102)
+* [Feature Provide a new open API to return the organization list](https://github.com/apolloconfig/apollo-java/pull/102)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * [Feature Provide a new open APl to return the organization list](https://github.com/apolloconfig/apollo-java/pull/102) | |
| * [Feature Provide a new open API to return the organization list](https://github.com/apolloconfig/apollo-java/pull/102) |
🧰 Tools
🪛 LanguageTool
[grammar] ~9-~9: Ensure spelling is correct
Context: ...-------- * [Feature Provide a new open APl to return the organization list](https:...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@changes/changes-2.5.0.md` at line 9, Fix the typo in the release note bullet
by replacing "APl" with "API" in the string "* [Feature Provide a new open APl
to return the organization
list](https://github.com/apolloconfig/apollo-java/pull/102)" so it reads
"Provide a new open API to return the organization list"; update the exact text
in changes-2.5.0.md where that bullet appears (look for the phrase "Provide a
new open APl to return the organization list").
What's the purpose of this PR
Post-release housekeeping for Apollo Java 2.6.0: bump next SNAPSHOT and archive CHANGES.md.
Which issue(s) this PR fixes:
Fixes #N/A (release task)
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
Documentation
Chores