Skip to content

Set modified when creating QR code for box #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pylipp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set modified when creating QR code for box #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pdf/qr.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function () {
[$id, $hash] = generateQRIDForDB();

if ($labels[$i]) {
db_query('UPDATE stock SET qr_id = :qr_id WHERE id = :id', ['id' => $labels[$i], 'qr_id' => $id]);
Copy link
Member

@HaGuesto HaGuesto Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pylipp could we change it that the now timestamp matches the now timestamp in the history message?

Copy link
Contributor Author

@pylipp pylipp Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a refactoring of the simpleBulkSaveChangeHistory function, I'd move it to a separate PR.
Because this function is used in four places, most with UPDATE modified = NOW() before.

Copy link
Contributor Author

@pylipp pylipp Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#814

db_query('UPDATE stock SET qr_id = :qr_id, modified = NOW(), modified_by = :user WHERE id = :id', ['id' => $labels[$i], 'qr_id' => $id, 'user' => $_SESSION['user']['id']]);
$box_ids_without_qr[] = $labels[$i];
}
}
Expand Down