Skip to content

Inconsistent behaviour when fits reach max evaluations #220

@damskii9992

Description

@damskii9992

We currently support 3 different minimization engines, all these 3 engines behaves differently when the fit does not converge:

DFO

DFO will throw a FitError with an appropriate error message:
Image

LMFit

LMFit does not throw or warns, but its success flag is properly set to False

Bumps

Bumps does not throw or warns, AND its success flag is wrongly set to True because the fit works and doesn't throw anywhere (it JUST reaches max_iterations).

While not a bug, I also wish to have evaluations as a result in our Result object, so that it can easily be inspected for profiling without having to know its underlying name in our minimizer backends.

Metadata

Metadata

Assignees

No one assigned

    Labels

    [area] fittingUmbrella for fitting related work[priority] highShould be prioritized soon[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions