Skip to content

[Bugfix] Sort network mounts alphabetically #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavierjurado wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

[Bugfix] Sort network mounts alphabetically #3695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/nemo-places-sidebar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,16 @@ sort_places_func (gconstpointer a,
return g_utf8_collate (((PlaceInfo *) a)->name, ((PlaceInfo *) b)->name);
}

static gint
sort_mounts_func (gconstpointer a,
gconstpointer b)
{
g_autofree gchar *name_a = g_mount_get_name (G_MOUNT (a));
g_autofree gchar *name_b = g_mount_get_name (G_MOUNT (b));

return g_utf8_collate (name_a, name_b);
}

static PlaceInfo *
new_place_info (PlaceType place_type,
SectionType section_type,
Expand Down Expand Up @@ -1254,7 +1264,7 @@ update_places (NemoPlacesSidebar *sidebar)

g_list_free_full (network_volumes, g_object_unref);

network_mounts = g_list_reverse (network_mounts);
network_mounts = g_list_sort(network_mounts, sort_mounts_func);
for (l = network_mounts; l != NULL; l = l->next) {
mount = l->data;
root = g_mount_get_default_location (mount);
Expand Down