Draft
Conversation
Introduces caldav/jmap/ as a purely additive package providing JMAP calendar support alongside the existing CalDAV client. No existing files are modified.
…nd parse_event_set to 6-tuple
tobixen
reviewed
Feb 20, 2026
caldav/jmap/convert/jscal_to_ical.py
Outdated
|
|
||
| if time_zone: | ||
| try: | ||
| import pytz # type: ignore[import] |
Collaborator
Author
There was a problem hiding this comment.
Yeah, I was thinking to replace it to use zoneinfo instead
Collaborator
Author
There was a problem hiding this comment.
The semantics are identical
SashankBhamidi
commented
Feb 20, 2026
SashankBhamidi
commented
Feb 20, 2026
SashankBhamidi
commented
Feb 20, 2026
Apply suggestions from code review
Apply suggestions from code review
Collaborator
Author
|
@tobixen Is this better now? I’ll pull it tomorrow and work on CI errors. I committed the changes as suggestions for now. I’m at a friend’s place playing FIFA at the moment, won't be back until tomorrow morning :) |
SashankBhamidi
commented
Feb 20, 2026
SashankBhamidi
commented
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
caldav/jmap/— a synchronous JMAP client for calendar operations, sitting alongside the existing CalDAV client.