Skip to content

Fix crash with crossref div and conditional visibility #13995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cderv wants to merge 3 commits into
base: main
Choose a base branch
from
+256 −2
Open

Fix crash with crossref div and conditional visibility #13995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2c289
Fix crash with crossref table div and conditional visibility
cderv Feb 4, 2026
fc83e91
Add test coverage for content-hidden custom node scenarios (#13992)
cderv Feb 4, 2026
5922beb
Add explanatory comment for defensive clearHiddenVisibleAttributes call
cderv Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,4 @@ All changes included in 1.9:
- ([#13890](https://github.com/quarto-dev/quarto-cli/issues/13890)): Fix render failure when using `embed-resources: true` with input path through a symlinked directory. The cleanup now resolves symlinks before comparing paths.
- ([#13907](https://github.com/quarto-dev/quarto-cli/issues/13907)): Ignore AI assistant configuration files (`CLAUDE.md`, `AGENTS.md`) when scanning for project input files and in extension templates, similar to how `README.md` is handled.
- ([#13935](https://github.com/quarto-dev/quarto-cli/issues/13935)): Fix `quarto install`, `quarto update`, and `quarto uninstall` interactive tool selection.
- ([#13992](https://github.com/quarto-dev/quarto-cli/issues/13992)): Fix crash when rendering div with both cross-reference ID and conditional visibility to PDF.
14 changes: 12 additions & 2 deletions src/resources/filters/customnodes/content-hidden.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,18 @@ _quarto.ast.add_handler({
local visible = is_visible(node)
if visible then
local el = node.node
clearHiddenVisibleAttributes(el)
return el.content
-- Handle case where slot content was transformed (e.g., Div → FloatRefTarget → Table)
if is_regular_node(el, "Div") then
-- Defensive: parse() already stripped visibility attrs (lines 46-47), so this is
-- typically a no-op. Kept as safety net in case future code adds attrs between
-- parse and render. See issue #13992 investigation for AST trace evidence.
clearHiddenVisibleAttributes(el)
return el.content
else
-- Slot was transformed to another type (Table, etc.)
-- Return the rendered element wrapped in Blocks
return pandoc.Blocks({el})
end
else
return {}
end
Expand Down
31 changes: 31 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-figure.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
title: "Conditional visibility with figure (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Figure content visible', 'fig-cond', '\\begin{figure}', 'Figure~\\ref\{fig-cond\}']
- []
html:
ensureHtmlElements:
- []
- ['#fig-cond']
ensureFileRegexMatches:
- []
- ['Figure content visible']
typst:
ensureTypstFileRegexMatches:
- ['#figure', 'Figure content visible', '#ref\(<fig-cond>']
- []
native: default
---

See @fig-cond for conditional figure.

::: {#fig-cond .content-visible unless-format="html"}
![]({{< placeholder 300 >}})

Figure content visible
:::
32 changes: 32 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-listing.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
title: "Conditional visibility with listing (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Listing content visible', 'lst-cond', '\\begin{codelisting}', 'Listing~\\ref\{lst-cond\}']
- []
html:
ensureHtmlElements:
- []
- ['#lst-cond']
ensureFileRegexMatches:
- []
- ['Listing content visible']
typst:
ensureTypstFileRegexMatches:
- ['Listing content visible', '#ref\(<lst-cond>']
- []
native: default
---

See @lst-cond for conditional listing.

::: {#lst-cond .content-visible unless-format="html"}
```python
# Listing content visible
print("hello")
```
:::
30 changes: 30 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-nested-callout.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
title: "Conditional visibility with nested callout (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Nested callout visible', 'tcolorbox', 'quarto-callout-note']
- []
html:
ensureHtmlElements:
- []
- ['div.callout']
ensureFileRegexMatches:
- []
- ['Nested callout visible']
typst:
ensureTypstFileRegexMatches:
- ['Nested callout visible', '#callout']
- []
---

This tests a callout nested inside a conditional visibility div.

::: {.content-visible unless-format="html"}
::: {.callout-note}
Nested callout visible.
:::
:::
31 changes: 31 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-nested-tabset.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
title: "Conditional visibility with nested tabset (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- []
- ['Nested tabset visible', 'Tab A']
html:
ensureHtmlElements:
- ['div.panel-tabset']
- []
ensureFileRegexMatches:
- ['Nested tabset visible', 'Tab A']
- []
typst:
ensureTypstFileRegexMatches:
- []
- ['Nested tabset visible', 'Tab A']
---

This tests a tabset nested inside a conditional visibility div.

::: {.content-visible when-format="html"}
::: {.panel-tabset}
### Tab A
Nested tabset visible.
:::
:::
25 changes: 25 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-plain.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
title: "Conditional visibility with plain div (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Plain div content visible']
- []
html:
ensureFileRegexMatches:
- []
- ['Plain div content visible']
typst:
ensureTypstFileRegexMatches:
- ['Plain div content visible']
- []
---

This tests the baseline case of a plain div with `.content-visible`.

::: {.content-visible unless-format="html"}
Plain div content visible.
:::
25 changes: 25 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-proof.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
title: "Conditional visibility with proof (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Proof content visible', '\\begin{proof}', '\\end{proof}']
- []
html:
ensureFileRegexMatches:
- []
- ['Proof content visible']
typst:
ensureTypstFileRegexMatches:
- ['#emph\[Proof\]\. Proof content visible']
- []
---

This tests a proof div with `.proof` class and `.content-visible`.

::: {.proof .content-visible unless-format="html"}
Proof content visible.
:::
39 changes: 39 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-table.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
title: "Crossref table with conditional visibility (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Type 1', 'Type 2', 'Item 1', 'Item 2', 'tbl-mytypes']
- []
html:
ensureHtmlElements:
- []
- ['#tbl-mytypes', 'table']
ensureFileRegexMatches:
- []
- ['Type 1', 'Type 2', 'Item 1', 'Item 2']
typst:
ensureTypstFileRegexMatches:
- ['#ref\(<tbl-mytypes>', 'Type 1', 'Type 2', 'Item 1', 'Item 2']
- []
native: default
---

This tests that a table div with both a cross-reference ID and conditional visibility renders correctly.

See @tbl-mytypes for the table.

::: {#tbl-mytypes .content-visible unless-format="html"}

| Type 1 | Type 2 |
| ------ | ------ |
| Item 1 | Item 2 |

: Test table caption

:::

The table above should appear in PDF and Typst but not HTML.
30 changes: 30 additions & 0 deletions tests/docs/smoke-all/2026/02/04/issue-13992-theorem.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
title: "Conditional visibility with theorem (#13992)"
keep-tex: true
keep-typ: true
_quarto:
tests:
pdf:
ensureLatexFileRegexMatches:
- ['Theorem content visible', 'thm-cond', '\\begin\{theorem\}']
- []
html:
ensureHtmlElements:
- []
- ['#thm-cond']
ensureFileRegexMatches:
- []
- ['Theorem content visible']
typst:
ensureTypstFileRegexMatches:
- ['Theorem content visible', '#ref\(<thm-cond>', '#theorem']
- []
---

See @thm-cond for conditional theorem.

::: {#thm-cond .content-visible unless-format="html"}
## Test Theorem

Theorem content visible.
:::
Loading