fix: focus textarea instead of terminal when creating new chat#182
Open
erenbertr wants to merge 1 commit into21st-dev:mainfrom
Open
fix: focus textarea instead of terminal when creating new chat#182erenbertr wants to merge 1 commit into21st-dev:mainfrom
erenbertr wants to merge 1 commit into21st-dev:mainfrom
Conversation
When the terminal panel is open and the user clicks "New Chat", focus was staying on the xterm textarea instead of moving to the chat editor. The requestAnimationFrame callback fired too early — before the browser's focus management settled after React's DOM updates. Switch to setTimeout(100ms) to ensure the editor focus call happens after all pending focus transitions complete. This matches the pattern already used in new-chat-form.tsx. Also adds proper cleanup (clearTimeout) to the useEffect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the terminal panel is open and the user clicks "New Chat", focus was staying on the xterm textarea instead of moving to the chat editor. The requestAnimationFrame callback fired too early — before the browser's focus management settled after React's DOM updates. Switch to setTimeout(100ms) to ensure the editor focus call happens after all pending focus transitions complete. This matches the pattern already used in new-chat-form.tsx.
Also adds proper cleanup (clearTimeout) to the useEffect.