Open
Conversation
| // Add state items filter. | ||
| String state = issue.getStateName(); | ||
| if (!TextUtils.isEmpty(state) && !topics.contains(state)) { | ||
| topics.add(state); |
Collaborator
There was a problem hiding this comment.
Are we good co-mingling states and categories in the same alphabetically sorted filters list?
e.g. "Texas, ICE, Maryland, Healthcare" could appear.
I dunno what the better UX would be....don't want to have separate filters. Could have "state: " and "category: " prefixes on each filter item?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
If state-level issues are present, adds the state to the list of items to filter by. Moves state name getting logic from IssuesAdapter to Issue.java so it can be reused; adds unit tests.
Also refactors common lines into helper in IssuesAdapterTest.
Were the changes tested?
have not been included