Use location instead of the undefined query property#100
Open
kyusu wants to merge 1 commit into60frames:masterfrom
Open
Use location instead of the undefined query property#100kyusu wants to merge 1 commit into60frames:masterfrom
kyusu wants to merge 1 commit into60frames:masterfrom
Conversation
Author
|
Hmm, interesting the checks fail for files I haven't touched. |
Member
|
@kyusu good catch... it also looks like There doesn't appear to be much in the way of documentation for const { location, params } = renderProps;
return (
component
.fetchData({
dispatch: store.dispatch,
location,
params
})
// Make sure promise always successfully resolves
.catch(() => {})
);re: CI, it looks like there's a mismatched version of prettier -- if you make the above change I'll fix that up and merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @richardscarrott,
I've found something which I consider a minor bug in your boilerplate. In the
fetchComponentDatain theserver.jsyou are destructuring therenderPropsintoquery,paramsandhistory. Butqueryis undefined. If I want to access the query parameters, I first have to get thelocationproperty and then access thequery.