Skip to content

Add a guide for MaxText checkpointing solutions.#2248

Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
test_797414644
Closed

Add a guide for MaxText checkpointing solutions.#2248
copybara-service[bot] wants to merge 1 commit intomainfrom
test_797414644

Conversation

@copybara-service
Copy link
Contributor

@copybara-service copybara-service bot commented Aug 27, 2025

Add a guide for MaxText checkpointing solutions.

Copy link
Collaborator

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all - I left a number of comments.

One high-level comment is that these files are not yet integrated into the documentation pages, as they are not accounted for in any Table of Contents. Because I identified a number of sections which seem to be common between all types of checkpointing, my suggestion would be to have a "Checkpointing guide" parent page, with a toctree directive listing the child pages (emergency_checkpointing, gcs_checkpointing and multi_tier_checkpointing) and maybe containing some of the common sections identified in these files.

If we decide against creating this new page, these three files need to be added to the toctree here: https://github.com/AI-Hypercomputer/maxtext/blob/main/docs/guides.md

One final comment: it is unusual to see capitalization in file names. It is of course up to the team to decide what is best but I just wanted to mention in case it's an oversight.

Thanks!

@copybara-service copybara-service bot changed the title Add a guide for choosing MaxText checkpointing solutions. Add a guide for MaxText checkpointing solutions. Sep 2, 2025
@copybara-service copybara-service bot force-pushed the test_797414644 branch 5 times, most recently from 984ea0f to 5145ded Compare September 2, 2025 22:59
@copybara-service copybara-service bot force-pushed the test_797414644 branch 5 times, most recently from 13ec1e1 to 53243cb Compare September 3, 2025 06:57
@copybara-service copybara-service bot closed this Sep 3, 2025
@copybara-service copybara-service bot deleted the test_797414644 branch September 3, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants