-
Notifications
You must be signed in to change notification settings - Fork 467
Fix: Added sharding Constraints for MTP block (b/481469708) #3084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
d7c3fa6 to
ff787aa
Compare
f26e050 to
feaf592
Compare
91c73bc to
c068f39
Compare
suexu1025
approved these changes
Feb 9, 2026
Collaborator
suexu1025
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parambole
0a450f3 to
0a6fcf7
Compare
NuojCheng
approved these changes
Feb 10, 2026
RissyRan
approved these changes
Feb 10, 2026
Collaborator
RissyRan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment.
gobbleturk
approved these changes
Feb 10, 2026
suexu1025
approved these changes
Feb 11, 2026
a68791c to
45f5bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix involves adding a single, targeted sharding annotation to
target_token_embeddingwithin theMultiTokenPredictionLayer.__call__method usingsharding.maybe_shard_with_logical. This ensures that sharding is correctly propagated through the MTP layer's internal operations, including the projection and the subsequent transformer layer.FIXES: b/481469708
Tests
Verified with
train_compile.pyon the TPU backend and validated on ironwood run, where the model now trains without erros.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.