Skip to content

Conversation

@dipannita08
Copy link
Collaborator

Description

Background: A previous PR upgrading google-cloud-mldiagnostics through seed-env resulted in dependency issues caused by (1) cloud-tpu-diagnostics version 1.1.14 being yanked but dependency resolver unable to detect and exclude this (b/477743392) and (2) TPU lock file unable to pick up version google-cloud-mldiagnostics 0.5.10. This PR also inadvertently removed jaraco-functools, causing some more CI failures and was rolled back.

This change is attempting do a full update of both TPU and GPU deps.

FIXES: b/481140947

Tests

  • Run MaxText local
  • CI Tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's surprising to me that the GPU tests are failing when the GPU generated requirements file hasn't changed. Do you have any thoughts on why that would be?

@dipannita08
Copy link
Collaborator Author

It's surprising to me that the GPU tests are failing when the GPU generated requirements file hasn't changed. Do you have any thoughts on why that would be?

Yeah, I'm not sure either. Ran out of bandwidth last week to dig deeper.

Comment on lines +105 to +106
jax>=0.8.3
jaxlib>=0.8.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the jaxlib version and the jax version mismatched?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - these are moved from seed-env generated files - I'm not sure why this is the case.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which jax seed commit are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants