-
Notifications
You must be signed in to change notification settings - Fork 467
Update deps pinned to jax version 0.8.2 #3098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
17bc93f to
1738b3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's surprising to me that the GPU tests are failing when the GPU generated requirements file hasn't changed. Do you have any thoughts on why that would be?
Yeah, I'm not sure either. Ran out of bandwidth last week to dig deeper. |
| jax>=0.8.3 | ||
| jaxlib>=0.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the jaxlib version and the jax version mismatched?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - these are moved from seed-env generated files - I'm not sure why this is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which jax seed commit are you using?
Description
Background: A previous PR upgrading google-cloud-mldiagnostics through seed-env resulted in dependency issues caused by (1)
cloud-tpu-diagnosticsversion1.1.14being yanked but dependency resolver unable to detect and exclude this (b/477743392) and (2) TPU lock file unable to pick up versiongoogle-cloud-mldiagnostics 0.5.10. This PR also inadvertently removedjaraco-functools, causing some more CI failures and was rolled back.This change is attempting do a full update of both TPU and GPU deps.
FIXES: b/481140947
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.