-
Notifications
You must be signed in to change notification settings - Fork 467
move experimental folder to src/maxtext #3119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+43
−6,003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Feb 10, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of test failures which look unrelated. Thanks @khatwanimohit
dipannita08
approved these changes
Feb 11, 2026
523c412 to
4b8066a
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Imported from GitHub PR #3119 # Description move experimental folder to src/maxtext *Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned. This label is used for administrative purposes. Please do not add it manually. *Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 4b8066a by Mohit Khatwani <mohitkhatwani@google.com>: move experimental folder to src/maxtext Merging this change closes #3119 PiperOrigin-RevId: 868429192
4 tasks
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Imported from GitHub PR #3119 # Description move experimental folder to src/maxtext *Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned. This label is used for administrative purposes. Please do not add it manually. *Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 4b8066a by Mohit Khatwani <mohitkhatwani@google.com>: move experimental folder to src/maxtext Merging this change closes #3119 PiperOrigin-RevId: 868429192
copybara-service bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Imported from GitHub PR #3119 # Description move experimental folder to src/maxtext *Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned. This label is used for administrative purposes. Please do not add it manually. *Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests. # Tests CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- 4b8066a by Mohit Khatwani <mohitkhatwani@google.com>: move experimental folder to src/maxtext Merging this change closes #3119 PiperOrigin-RevId: 868429192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move experimental folder to src/maxtext
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.