Skip to content

Add \r and \f as separators for shell commands #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bitterpanda63 merged 2 commits into from
Feb 11, 2026
Merged

Add \r and \f as separators for shell commands #584

bitterpanda63 merged 2 commits into from
Feb 11, 2026
+59 −1

Conversation

@bitterpanda63
Copy link
Member

@bitterpanda63 bitterpanda63 commented Feb 6, 2026 •
edited by aikido-pr-checks bot
Loading

Summary by Aikido

Security Issues: 0 🔍 Quality Issues: 1 Resolved Issues: 0

⚡ Enhancements

  • Added carriage-return and form-feed as separators and dangerous shell characters

More info

@bitterpanda63 bitterpanda63 marked this pull request as ready for review February 6, 2026 12:33
@bitterpanda63
add \r and \f as dangerous shell characters
5106015 
this is in case the command == the user input
@bitterpanda63 bitterpanda63 merged commit 87508ae into main Feb 11, 2026
83 of 84 checks passed
@bitterpanda63 bitterpanda63 deleted the fix-tabs-bypasses-for-shell-injection branch February 11, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hansott hansott hansott approved these changes

+1 more reviewer

@aikido-pr-checks aikido-pr-checks[bot] aikido-pr-checks[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bitterpanda63 @hansott