TRD add digit phases to CTF encoding, collapse phases on reading.#14770
Merged
shahor02 merged 1 commit intoAliceO2Group:devfrom Dec 8, 2025
Merged
TRD add digit phases to CTF encoding, collapse phases on reading.#14770shahor02 merged 1 commit intoAliceO2Group:devfrom
shahor02 merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
bazinski
commented
Oct 27, 2025
- extract pretrigger phases from the cruhalfchamber header.
- encode it into the ctf into the upper 2 of 4 bits of the detector number.
- ctf is marginally bigger due to non sequential detector number, but only 2 bits not 4 due to collapsing the phase values in the raw reader. We only need the relative positions not the actual phase values.
- add the processing of the phases to the pulseheight processing with HD (high definition) appended to the new class, old one left in.
- parallelise the sort of the incoming structurs for the drawing of MCM, Padrow, Detector in TRD/qc/src/ augmented data structures for visualising MCM/Padrows.
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
14f7bcf to
54b2fac
Compare
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 54b2fac at 2025-10-27 21:22: Full log here. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 3fe8432 at 2025-11-13 11:25: Full log here. |
wille10
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.