Skip to content

Find Thrust + fix compilation on CUDA13#14801

Merged
davidrohr merged 3 commits intoAliceO2Group:devfrom
mpuccio:dev
Nov 12, 2025
Merged

Find Thrust + fix compilation on CUDA13#14801
davidrohr merged 3 commits intoAliceO2Group:devfrom
mpuccio:dev

Conversation

@mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Nov 7, 2025

No description provided.

@mpuccio mpuccio requested a review from a team as a code owner November 7, 2025 15:08
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Nov 7, 2025

Error while checking build/O2/fullCI_slc9 for 43819f6 at 2025-11-07 17:16:

[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/TPCZSLinkMapping.cxx.o
[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxContainer.cxx.o
[ 95%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologyPol.cxx.o
[ 96%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologySpline.cxx.o
[ 97%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/GPUTRDTrackO2.cxx.o
[ 97%] Linking CXX shared library libGPUTracking.so
[ 97%] Built target GPUTracking
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/standalone.cxx.o
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/utils/qconfig.cxx.o
[ 99%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/Base/GPUReconstructionTimeframe.cxx.o
[100%] Linking CXX executable ca
[100%] Built target ca
Install the project...
-- Install configuration: "RELEASE"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelList.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelIncludes.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionIncludesDeviceAll.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersRuntime.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoad.inc
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoadPrepare.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_AMPERE.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_TURING.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_VEGA.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_MI100.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2
++ mkdir -p etc/modulefiles
++ cat
+++ [[ slc == osx ]]
++ mkdir -p /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ rsync -a --delete etc/modulefiles/ /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ [[ -n '' ]]
++ [[ -n /alidist ]]
++ [[ -f /alidist/resources/FindO2GPU.cmake ]]
++ cmp -s /alidist/resources/FindO2GPU.cmake /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ grep '# FindO2GPU.cmake Version ' /alidist/resources/FindO2GPU.cmake
+++ awk '{print $4}'
+++ grep '# FindO2GPU.cmake Version ' /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ awk '{print $4}'
++ [[ ! 4 -gt 4 ]]
++ echo 'FindO2GPU.cmake differs in O2 compared to alidist'
FindO2GPU.cmake differs in O2 compared to alidist
++ exit 1

Full log here.

mpuccio added a commit to mpuccio/alidist that referenced this pull request Nov 7, 2025
@mpuccio
Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801
1cf5302
@mpuccio mpuccio requested a review from davidrohr as a code owner November 7, 2025 16:22
@mpuccio mpuccio changed the title Find Thrust in CUDA13 Find Thrust + fix compilation on CUDA13 Nov 7, 2025
@alibuild alibuild mentioned this pull request Nov 7, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Nov 7, 2025

Error while checking build/O2/fullCI_slc9 for 1161b1d at 2025-11-07 19:39:

[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/TPCZSLinkMapping.cxx.o
[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxContainer.cxx.o
[ 95%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologyPol.cxx.o
[ 96%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologySpline.cxx.o
[ 97%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/GPUTRDTrackO2.cxx.o
[ 97%] Linking CXX shared library libGPUTracking.so
[ 97%] Built target GPUTracking
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/standalone.cxx.o
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/utils/qconfig.cxx.o
[ 99%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/Base/GPUReconstructionTimeframe.cxx.o
[100%] Linking CXX executable ca
[100%] Built target ca
Install the project...
-- Install configuration: "RELEASE"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelList.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelIncludes.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionIncludesDeviceAll.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersRuntime.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoad.inc
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoadPrepare.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_AMPERE.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_TURING.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_VEGA.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_MI100.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2
++ mkdir -p etc/modulefiles
++ cat
+++ [[ slc == osx ]]
++ mkdir -p /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ rsync -a --delete etc/modulefiles/ /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ [[ -n '' ]]
++ [[ -n /alidist ]]
++ [[ -f /alidist/resources/FindO2GPU.cmake ]]
++ cmp -s /alidist/resources/FindO2GPU.cmake /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ grep '# FindO2GPU.cmake Version ' /alidist/resources/FindO2GPU.cmake
+++ awk '{print $4}'
+++ grep '# FindO2GPU.cmake Version ' /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ awk '{print $4}'
++ [[ ! 4 -gt 4 ]]
++ echo 'FindO2GPU.cmake differs in O2 compared to alidist'
FindO2GPU.cmake differs in O2 compared to alidist
++ exit 1

Full log here.

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 11, 2025 •
edited
Loading

@davidrohr @ktf can we merge this and alisw/alidist#6036 ?

@davidrohr
Copy link
Collaborator

davidrohr commented Nov 11, 2025

Hi @mpuccio : Please increase the version comment at the top of FindO2GPU.cmake in both PRs. Then we can merge it. The PR itself looks good.

@mpuccio
Copy link
Contributor Author

mpuccio commented Nov 11, 2025

Hi @davidrohr, thanks a lot! Done!

@davidrohr
Copy link
Collaborator

davidrohr commented Nov 11, 2025

And please also in the alidist PR

@davidrohr
Copy link
Collaborator

davidrohr commented Nov 11, 2025

never mind, just got the mail that you did it already...

@alibuild
Copy link
Collaborator

alibuild commented Nov 11, 2025

Error while checking build/O2/fullCI_slc9 for 95e3bea at 2025-11-11 18:55:

[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/TPCZSLinkMapping.cxx.o
[ 94%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxContainer.cxx.o
[ 95%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologyPol.cxx.o
[ 96%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/CalibdEdxTrackTopologySpline.cxx.o
[ 97%] Building CXX object GPU/GPUTracking/CMakeFiles/GPUTracking.dir/DataTypes/GPUTRDTrackO2.cxx.o
[ 97%] Linking CXX shared library libGPUTracking.so
[ 97%] Built target GPUTracking
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/standalone.cxx.o
[ 98%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/utils/qconfig.cxx.o
[ 99%] Building CXX object GPU/GPUTracking/Standalone/Benchmark/CMakeFiles/ca.dir/sw/SOURCES/O2/14801-slc9_x86-64/0/GPU/GPUTracking/Base/GPUReconstructionTimeframe.cxx.o
[100%] Linking CXX executable ca
[100%] Built target ca
Install the project...
-- Install configuration: "RELEASE"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libGPUTracking.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelList.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionKernelIncludes.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUReconstructionIncludesDeviceAll.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersRuntime.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoad.inc
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/include/GPU/GPUDefParametersLoadPrepare.h
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_AMPERE.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_TURING.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_VEGA.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/share/GPU/arch_param/gpu_const_param_MI100.par
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/ca" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libTPCFastTransformation.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
-- Installing: /sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so
-- Set non-toolchain portion of runtime path of "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone/libstandalone_support.so" to "/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2/standalone"
/sw/BUILD/86417ce65945de3a39ec979ffa71b429e65f5b63/O2
++ mkdir -p etc/modulefiles
++ cat
+++ [[ slc == osx ]]
++ mkdir -p /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ rsync -a --delete etc/modulefiles/ /sw/slc9_x86-64/O2/14801-slc9_x86-64-local1/etc/modulefiles
++ [[ -n '' ]]
++ [[ -n /alidist ]]
++ [[ -f /alidist/resources/FindO2GPU.cmake ]]
++ cmp -s /alidist/resources/FindO2GPU.cmake /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ grep '# FindO2GPU.cmake Version ' /alidist/resources/FindO2GPU.cmake
+++ awk '{print $4}'
+++ grep '# FindO2GPU.cmake Version ' /sw/SOURCES/O2/14801-slc9_x86-64/0/dependencies/FindO2GPU.cmake
+++ awk '{print $4}'
++ [[ ! 4 -gt 5 ]]
++ echo 'FindO2GPU.cmake differs in O2 compared to alidist'
FindO2GPU.cmake differs in O2 compared to alidist
++ exit 1

Full log here.

davidrohr pushed a commit to alisw/alidist that referenced this pull request Nov 11, 2025
@mpuccio
Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801 (#6036)
5f6c6d1 
* Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801

* Update FindO2GPU.cmake
@davidrohr davidrohr merged commit 72e6d01 into AliceO2Group:dev Nov 12, 2025
10 of 11 checks passed
vascobarroso pushed a commit to alisw/alidist that referenced this pull request Nov 13, 2025
@mpuccio @vascobarroso
Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801 (#6036)
8a382aa 
* Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801

* Update FindO2GPU.cmake
atriolo pushed a commit to atriolo/AliceO2 that referenced this pull request Nov 18, 2025
@mpuccio @atriolo
Find Thrust + fix compilation on CUDA13 (AliceO2Group#14801)
897c70d 
* Find Thrust in CUDA13

* Fix compatibility with CUDA13

* Update FindO2GPU.cmake version to 5
atriolo pushed a commit to atriolo/AliceO2 that referenced this pull request Nov 18, 2025
@mpuccio @atriolo
Find Thrust + fix compilation on CUDA13 (AliceO2Group#14801)
5f377b5 
* Find Thrust in CUDA13

* Fix compatibility with CUDA13

* Update FindO2GPU.cmake version to 5
mrtineide pushed a commit to mrtineide/alidist that referenced this pull request Nov 26, 2025
@mpuccio @mrtineide
Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801 (alisw#6036)
0ca263d 
* Align FindO2GPU.cmake to AliceO2Group/AliceO2#14801

* Update FindO2GPU.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpuccio @alibuild @davidrohr