Skip to content

Conversation

@jackal1-66
Copy link
Collaborator

  • Moved the TPCLoopers inclusion to Generator.cxx
  • Made forward declaration for GenTPCLoopers
  • Switched to normal pointer instead of unique_ptr (destroyed in Generator destructor) ==> moved outside ifdef scope, this was the main cause of the segmentation issue when using the external generators, such as Update tune from SCCR to QCDCR for pO and OO O2DPG#2256

@jackal1-66 jackal1-66 requested a review from sawenzel as a code owner February 3, 2026 18:31
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

{
/** destructor **/
#ifdef GENERATORS_WITH_TPCLOOPERS
delete mTPCLoopersGen;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to check if the pointer is actually not null before deleting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants