[MFT] update of comparator logic for noise map quality checks#2625
Merged
Barthelemy merged 2 commits intoAliceO2Group:masterfrom Dec 2, 2025
Merged
[MFT] update of comparator logic for noise map quality checks#2625Barthelemy merged 2 commits intoAliceO2Group:masterfrom
Barthelemy merged 2 commits intoAliceO2Group:masterfrom
Conversation
Edingrast
approved these changes
Nov 28, 2025
Collaborator
|
Hi @Barthelemy, I see some checks failed due to a TPC task (Detectors/TPC/base/test/testTPCCalDet.cxx) that was not part of this PR. Can you (or any other expert) please take a look? |
Barthelemy
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to QcMFTDigitCheck.cxx to fix comparator logic possibly leading to undefined behaviour if threshold values are met exactly. The compared terms were also rearranged for unification purposes.