Skip to content

fixes for 43.0.1: suppress G4 warnings, fix small issue in TrackTruthMatcher #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 3 commits into from
Feb 10, 2026
Merged

fixes for 43.0.1: suppress G4 warnings, fix small issue in TrackTruthMatcher #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa47da
suppress MF lookup errors from G4 in MagneticFieldWrapper.cpp
altsybee Feb 10, 2026
8d33b8a
suppress printouts for errors in GdmlDetectorConstruction.cpp
altsybee Feb 10, 2026
913c4e9
bypass problem with fake definition in TrackTruthMatcher
altsybee Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Examples/Algorithms/Geant4/src/MagneticFieldWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ void MagneticFieldWrapper::GetFieldValue(const G4double Point[4],
convertLength * Point[2]},
bCache);
if (!fieldRes.ok()) {
ACTS_ERROR("Field lookup error: " << fieldRes.error());
if (fabs(Point[0]) < 2000 && fabs(Point[1]) < 2000 && fabs(Point[2]) < 5000)
ACTS_ERROR("Field lookup error: " << fieldRes.error()
<< convertLength * Point[0] << " "
<< convertLength * Point[1] << " "
<< convertLength * Point[2]);
return;
}
// Get the field now
Expand Down
5 changes: 2 additions & 3 deletions Examples/Algorithms/TruthTracking/ActsExamples/TruthTracking/TrackTruthMatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,8 @@ ActsExamples::ProcessCode TrackTruthMatcher::execute(
}
const bool truthMatched =
static_cast<double>(nMajorityHits) /
(abs(eta < 1.5 ? (nParticleTruthHits > 11 ? 11 : nParticleTruthHits)
: nParticleTruthHits)) >=
m_cfg.matchingRatio;
(abs(eta) < 1.5 ? (nParticleTruthHits > 13 ? 13 : nParticleTruthHits)
: nParticleTruthHits) >= m_cfg.matchingRatio;

// ### IA:
ACTS_DEBUG("nMajorityHits="
Expand Down
2 changes: 1 addition & 1 deletion Examples/Detectors/Geant4Detector/src/GdmlDetectorConstruction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ G4VPhysicalVolume* GdmlDetectorConstruction::Construct() {
if (m_world == nullptr) {
G4GDMLParser parser;
// TODO how to handle errors
parser.Read(m_path);
parser.Read(m_path, false); // IA: // <- validation OFF
m_world = parser.GetWorldVolume();

// Create regions
Expand Down