Fixed forge automatic download and startup 1.14.4#56
Open
ImaniiTy wants to merge 1 commit intoAllTheMods:masterfrom
Open
Fixed forge automatic download and startup 1.14.4#56ImaniiTy wants to merge 1 commit intoAllTheMods:masterfrom
ImaniiTy wants to merge 1 commit intoAllTheMods:masterfrom
Conversation
I fixed the error that was happening when you tried to download without set a direct link to the forge installer and added a check to the new forge naming convention so the script can automatically startup the server now(maintaining compatibility with the older convention of course)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the error that was happening when you tried to download without set a direct link to the forge installer caused by a change on the forge website structure, making the old regexp fail. And I added a check to the new forge naming convention so the script can automatically startup the server(maintaining compatibility with the older convention of course).