Use serialized metadata size to calculate the cache entry cell#1484
Merged
zvonand merged 2 commits intoantalya-26.1from Mar 8, 2026
Merged
Use serialized metadata size to calculate the cache entry cell#1484zvonand merged 2 commits intoantalya-26.1from
zvonand merged 2 commits intoantalya-26.1from
Conversation
arthurpassos
added
port-antalya
ianton-ru
approved these changes
Mar 6, 2026
|
|
||
| size_t ParquetFileMetaDataWeightFunction::operator()(const parquet::FileMetaData & metadata) const | ||
| { | ||
| /// TODO fix-me: using the size on disk is not ideal, but it is the simplest and best we can do for now. |
There was a problem hiding this comment.
Why not ideal? As comment in CacheBase says, functor must return "approximate size" of the data.
Or it is mean that file size is not equal to used disk size and need increase to the file system block size?
Collaborator
Author
There was a problem hiding this comment.
I think the size matches the size on disk. I say not ideal because imo the ideal would be the in memory data structure sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Quick workaround for Altinity/clickhouse-regression#114
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: