Closed
Conversation
Member
|
Hey! Thanks for the PR. Did you test it? I think it requires more than just the frontend changes. Can you confirm if it works without that? Then I will do a full review. |
Author
|
Hey! Yes — I tested it locally and confirmed it works with frontend-only changes. The URL parameters correctly pre-select vehicle, version, and board, and invalid params fall back safely to defaults. No backend changes were needed for this to function. I’ve pushed fixes in the latest commits to address the issues. Please let me know if you’d like any additional changes or tests. Happy to adjust 👍 |
shiv-tyagi
reviewed
Feb 14, 2026
Adds support for pre-selecting vehicle, version, and board from URL parameters. Example: ?vehicle=copter&version=stable&board=pixhawk - Frontend-only change - No backend changes - Safe fallback if parameters are invalid - Does not affect existing behavior This allows external links to directly open pre-configured build selections.
ryanbasic1
force-pushed
the
preselect-dropdown-url
branch
from
09ab069 to
9a111be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for pre-selecting vehicle, version, and board from URL parameters.
Example:
?vehicle=copter&version=stable&board=pixhawk
**- Frontend-only change
This allows external links to directly open pre-configured build selections.**
Closes #181