Conversation
|
rickyrombo
left a comment
There was a problem hiding this comment.
so iiuc we grab a mutex, do our operation, and the next operation will wait for that mutex before doing its operation, at which point even if it refetches it'll be up to date?
yeah, but the mutex lets go right when we insert the change into the confirmer. i don't know if i like it though, doing another pass at the simpler solve of just not fetching when we have optimistic state. |
3bb5cbc to
6818ffc
Compare
Add playlist update locking mechanism to prevent optimistic re-fetching from clobbering pending updates.
Tested:
A simpler solve would be to just not refetch before update while something is in the confirmer, but that isn't super great because we handle updates async and still could bite you if you're on the add tracks to playlist menu and just clicking add repeatedly.
Fixes two additional bugs: