fix missing prefix V1 on sio event Bridge#3
Open
jooncheol wants to merge 1 commit intoAutoDRIVE-Ecosystem:mainfrom
Open
fix missing prefix V1 on sio event Bridge#3jooncheol wants to merge 1 commit intoAutoDRIVE-Ecosystem:mainfrom
jooncheol wants to merge 1 commit intoAutoDRIVE-Ecosystem:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code made abnormal behavior of Simulator.
If you check the Socket Client Code in the Simulator, there are 2 lines that expect to parse "Reset" with "V1". But the Devkit's Server side SIO handler emits (send) the custom event "Bridge" with "Reset" without "V1 " prefix.
These are the link of simulator side sio code that were affected from the original devkit code.
After this patch, the simulator didn't have any abnormal behavior on my environment. (Simulator on macOS, devkit on arm64 VM)