Skip to content

[ACR] az acr replication create|update: Add --global-endpoint-routing flag and deprecate --region-endpoint-enabled flag#32954

Open
lizMSFT wants to merge 3 commits intoAzure:devfrom
lizMSFT:zoeyli/acr/replication_region_endpoint
Open

[ACR] az acr replication create|update: Add --global-endpoint-routing flag and deprecate --region-endpoint-enabled flag#32954
lizMSFT wants to merge 3 commits intoAzure:devfrom
lizMSFT:zoeyli/acr/replication_region_endpoint

Conversation

@lizMSFT
Copy link
Member

@lizMSFT lizMSFT commented Mar 11, 2026

Related command
az acr replication create
az acr replication update

Description
Customers have been confusing --region-endpoint-enabled (per-geo-replica, controls global endpoint routing) with the registry-level --regional-endpoints flag (az acr create|update, enables regional endpoint URLs)

This PR introduces --global-endpoint-routing as the new flag for az acr replication create|update and deprecates --region-endpoint-enabled with a hidden alias and breaking change announcement, to resolve customer confusion with the registry-level --regional-endpoints flag.

This PR does not remove --region-endpoint-enabled. A follow-up PR will be created before the breaking change window to complete the rename by removing the deprecated flag.

Testing Guide
image
image

History Notes
[ACR] az acr replication create|update: Add --global-endpoint-routing flag and deprecate --region-endpoint-enabled to avoid confusion with registry-level --regional-endpoints


This checklist is used to make sure that common guidelines for a pull request are followed.

@lizMSFT lizMSFT requested review from jsntcy and yanzhudd as code owners March 11, 2026 03:42
Copilot AI review requested due to automatic review settings March 11, 2026 03:42
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 11, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the ACR replication routing flag to reduce confusion with registry-level regional endpoints by introducing --global-endpoint-routing on az acr replication create|update, while keeping --region-endpoint-enabled as a deprecated alias and announcing the deprecation via breaking-change infrastructure.

Changes:

  • Add --global-endpoint-routing option (aliasing the existing region_endpoint_enabled argument) for acr replication create|update.
  • Deprecate --region-endpoint-enabled via argument option deprecation and register upcoming breaking-change notices.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/azure-cli/azure/cli/command_modules/acr/_params.py Introduces --global-endpoint-routing option and defines the deprecated alias behavior for the old flag.
src/azure-cli/azure/cli/command_modules/acr/_breaking_change.py Registers breaking-change deprecation notices for --region-endpoint-enabled on replication create/update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lizMSFT lizMSFT requested a review from kairu-ms as a code owner March 11, 2026 04:04
@lizMSFT lizMSFT requested a review from johnsonshi March 12, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants