Enforce runtime config minimum property requirements#3242
Draft
Enforce runtime config minimum property requirements#3242
Conversation
Co-authored-by: Aniruddh25 <3513779+Aniruddh25@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce runtime config minimum property requirements
Enforce runtime config minimum property requirements
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Enforces the documented minimum property requirements for
RuntimeConfig:data-source-filesis present (multi-config), onlyruntimeis required at the top level —data-sourceandentitiesshould not be requiredautoentitiesis present,data-sourceis required butentitiesis notendpointis required whenazure-key-vaultis specifiedWhat is this change?
JSON Schema (
dab.draft.schema.json)required: ["data-source", "entities"]+ top-levelif/thenwith anallOfblock of three conditional rules:data-sourcerequired unlessdata-source-filesis presententitiesrequired unlessautoentitiesordata-source-filesis presentazure-key-vault.endpointrequired whenazure-key-vaultis present (preserved)RuntimeConfigconstructorDataSourceto benullwhenDataSourceFilesis provided; does not throwDataApiBuilderExceptionin that case_dataSourceNameToDataSourceinit to skip nullDataSourceDataSourceFilesis presentallEntities?.Concat(...)returnednullwhen the main config had noentitiessection, silently dropping all sub-config entitiesRuntimeConfigLoader.TryParseConfigconfig.DataSource is not nullto preventNullReferenceExceptionin multi-config scenariosHow was this tested?
TestValidateConfigPassesWithAutoentitiesAndNoEntities— config withautoentitiesand noentitiesparses successfullyTestValidateConfigPassesWithDataSourceFilesOnly— multi-config withdata-source-filesand nodata-source/entitiesparses successfullyTestValidateConfigFailsWithNoDataSourceandTestValidateConfigFailsWithNoEntitiescontinue to pass, confirming single-config validation is unaffectedSample Request(s)
Valid multi-config top-level (only
runtime+data-source-filesrequired):{ "$schema": "...", "runtime": { ... }, "data-source-files": ["child-mssql.json", "child-pgsql.json"] }Valid autoentities config (
entitiesnot required):{ "$schema": "...", "data-source": { "database-type": "mssql", "connection-string": "..." }, "runtime": { ... }, "autoentities": { "myGroup": { "patterns": { "include": ["%.%"] } } } }Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
azuread/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35279 --endpoint 127.0.0.1:035279 --role client --parentprocessid 5825 --telemetryoptedin false seBuilder.cs tnet/tools/grep grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 37545 --endpoint 127.0.0.1:037545 --role client --parentprocessid 6003 --telemetryoptedin false ntParser.cs de/node/bin/grepValidateDatabaseType\|runtimeConfig\.DataSource\b grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35393 --endpoint 127.0.0.1:035393 --role client --parentprocessid 6528 --telemetryoptedin false(dns block)custom/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35279 --endpoint 127.0.0.1:035279 --role client --parentprocessid 5825 --telemetryoptedin false seBuilder.cs tnet/tools/grep grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 37545 --endpoint 127.0.0.1:037545 --role client --parentprocessid 6003 --telemetryoptedin false ntParser.cs de/node/bin/grepValidateDatabaseType\|runtimeConfig\.DataSource\b grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35393 --endpoint 127.0.0.1:035393 --role client --parentprocessid 6528 --telemetryoptedin false(dns block)entraid/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35279 --endpoint 127.0.0.1:035279 --role client --parentprocessid 5825 --telemetryoptedin false seBuilder.cs tnet/tools/grep grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 37545 --endpoint 127.0.0.1:037545 --role client --parentprocessid 6003 --telemetryoptedin false ntParser.cs de/node/bin/grepValidateDatabaseType\|runtimeConfig\.DataSource\b grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35393 --endpoint 127.0.0.1:035393 --role client --parentprocessid 6528 --telemetryoptedin false(dns block)xxxxx/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35279 --endpoint 127.0.0.1:035279 --role client --parentprocessid 5825 --telemetryoptedin false seBuilder.cs tnet/tools/grep grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 37545 --endpoint 127.0.0.1:037545 --role client --parentprocessid 6003 --telemetryoptedin false ntParser.cs de/node/bin/grepValidateDatabaseType\|runtimeConfig\.DataSource\b grep(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/Cli.Tests.deps.json /home/REDACTED/work/data-api-builder/data-api-builder/src/out/tests/net8.0/testhost.dll --port 35393 --endpoint 127.0.0.1:035393 --role client --parentprocessid 6528 --telemetryoptedin false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.