-
Notifications
You must be signed in to change notification settings - Fork 319
Fix IOException in MSSQL pipeline by disposing config file watchers #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronburtle
wants to merge
9
commits into
main
Choose a base branch
from
dev/aaronburtle/MSSQLIntegrationTestPipelineCleanupFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e8d744e
try fix race condntion in cleanup
aaronburtle 2fbba2c
Merge branch 'main' into dev/aaronburtle/MSSQLIntegrationTestPipeline…
aaronburtle 70397af
Update src/Config/FileSystemRuntimeConfigLoader.cs
aaronburtle b4b0979
Update src/Config/ConfigFileWatcher.cs
aaronburtle 813f054
Merge branch 'main' into dev/aaronburtle/MSSQLIntegrationTestPipeline…
aaronburtle 369c235
Merge branch 'main' into dev/aaronburtle/MSSQLIntegrationTestPipeline…
souvikghosh04 aa0a5a1
add some logging for clarity
aaronburtle 737e2b0
Merge branch 'dev/aaronburtle/MSSQLIntegrationTestPipelineCleanupFix'…
aaronburtle 366e6f5
Merge branch 'main' into dev/aaronburtle/MSSQLIntegrationTestPipeline…
aaronburtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true auto-dispose (as mentioned in PR description) of
FileSystemRuntimeConfigLoaderwhen TestServer shuts down can be done withusingblock. tests inConfigurationTests.cscreateTestServerwithout using. If the server isn't explicitly disposed, the DI container'sIDisposablecleanup may never run and the file watcher could be undisposed. retry inCleanupAfterEachTestcovers this as a safety net but the more correct fix would be ensuring those TestServer instances are disposed. This could be a follow-up PR if not possible in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the 20 or so TestServer instances that don't have
usingwon't trigger the auto-dispose, Ill follow up on this in a future PR to keep the scope of this one from growing, and the CleanupAfterEachTest should cover us in the meantime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronburtle,
If we dont add
usingin this same change, the PR's title is not serving its purpose. It is not disposing the file watchers. It is only implementing the dispose function.I think all those FileSystemRuntimeConfigLoader should be actually disposed as well in this same PR.