Merged
Conversation
…ces (Azure#452) * add selection mode that places namespace and namespace scoped resources Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * remove namespace selector must be 1st restriction Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * use CEL validation Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * try double quote Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> * simplify if else Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> --------- Signed-off-by: Wei Weng <Wei.Weng@microsoft.com> Co-authored-by: Wei Weng <Wei.Weng@microsoft.com>
Signed-off-by: Simon Waight <simon.waight@microsoft.com>
Signed-off-by: Wei Weng <Wei.Weng@microsoft.com>
4ae41b9 to
d3ed206
Compare
This reverts commit 4d96d72.
ytimocin
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
b625d19 fix: correct pre-selected to preselected in scheduler framework test (#492)
b3e2321 feat: new selection mode so that CRP can select some namespace resources (#452)
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer