Merged
Conversation
awilfox
reviewed
Nov 6, 2025
Comment on lines
36
to
+38
| return LINK_TEXT_ALMA if self == ALMA | ||
| return LINK_TEXT_TIND if self == TIND | ||
|
|
||
| LINK_TEXT_TIND if self == TIND |
Member
There was a problem hiding this comment.
I'm wondering if these should be converted to case..when..else..end at some point, just in a hand wavy future update. Would be more maintainable and and make the else nil more explicit.
Member
Author
There was a problem hiding this comment.
sounds good - this, i believe, was a rubocop autocorrection.
awilfox
approved these changes
Nov 6, 2025
Member
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looks great. Glad the Dockerfile and GitHub workflow agree on Ruby version now (it looks like the Dockerfile used to use 3.0.x despite GitHub using 3.1). r+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.