Open
Conversation
anarchivist
approved these changes
Feb 4, 2026
Member
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
looks good, but two clarifying questions. r+ once we address/discuss them.
| @@ -1,3 +1,7 @@ | |||
| # Current Changelog moved to GitHub releases page | |||
Member
There was a problem hiding this comment.
i don't think this is true - we might have been lax about updating the changelog though. can we clarify how we're moving forward?
|
|
||
| OkComputer.logger = Rails.logger | ||
| OkComputer.check_in_parallel = true | ||
| OkComputer.check_in_parallel = !Rails.env.test? |
Member
There was a problem hiding this comment.
have we run into issues with parallel checks when RAILS_ENV=test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OkComputer health check GET requests can take time to respond. This PR brings in the Berkeley_Library-Util gem that adds a HEAD based
BerkeleyLibrary::Util::HeadCheckto replace OkComputer'sOkComputer::HttpCheck.