models: Validate Bibliographic::HostBibTask.email#11
Open
Conversation
Member
Author
|
fascinating, neither of those tests fail on my local computer. |
This ensures we do not create jobs without email addresses. Additionally, add email address attributes to the test user data. Closes: AP-577
awilfox
force-pushed
the
awilfox/AP-577-validate-biblio-email
branch
from
8d7527e to
2478d58
Compare
Contributor
|
@awilfox I pulled the branch and tested it locally, when uploaded a bib batch, it gave a 500 error. Could you try it locally with these steps?
For the previous error 'ArgumentError: SMTP to address may not be blank: [].', I login in Calnet, how can my email is blank? All calnet user should have an email. We need some investigation on it. |
Contributor
There was a problem hiding this comment.
This is using an email of a former employee in LIT. I think they probably put it in there but not sure if we should still be using it. Looks like it's used in several places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we do not create jobs without email addresses.
Closes: AP-577
@yzhoubk since you were the one who was running into jobs without email addresses while testing #10, would you be able to try this branch out and see if this helps?
I'm wondering if one of the test jobs was firing off, since they didn't specify an email. At any rate, having this validation should help us catch out any places we're missing the email in the future.