Allow digit grouping in coercion from character#17
Open
balwierz wants to merge 2 commits intoBioconductor:develfrom
Open
Allow digit grouping in coercion from character#17balwierz wants to merge 2 commits intoBioconductor:develfrom
balwierz wants to merge 2 commits intoBioconductor:develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large numbers are often divided into groups using a delimeter to ease of reading. English often uses comma to create groups of three for thousands, millions etc. IUPAC and International Bureau of Weights and Measures recommend using spaces.
Wikipedia on digit grouping
Some genomic software uses digit grouping. Notably, IGV and UCSC genome browser use comma for digit grouping.
This pull request allows for a use of commas and spaces in coercion to IRanges from character by stripping all commas and spaces from the input strings. It should work with any currently legal format plus allow for spaces and commas.
PS. This is code extends GenomicRanges coercion from character as well. If this pull request is approved, error message in
.from_character_to_GRangesin GenomicRanges needs to be updated as well.