Skip to content

feat(sdk-coin-trx): increase default transaction expiration to 3 hours#8230

Merged
Vijay-Jagannathan merged 1 commit intomasterfrom
COIN-7612
Mar 3, 2026
Merged

feat(sdk-coin-trx): increase default transaction expiration to 3 hours#8230
Vijay-Jagannathan merged 1 commit intomasterfrom
COIN-7612

Conversation

@Vijay-Jagannathan
Copy link
Contributor

Summary

  • Change TRANSACTION_DEFAULT_EXPIRATION from 1 hour (3600000ms) to 3 hours (10800000ms) for all TRX transaction types (native transfers, token transfers, freeze, unfreeze, vote, delegate, undelegate, withdraw)
  • Add test in tokenTransferBuilder.ts to verify token transfers use the 3-hour default expiration

Test plan

  • Verify token transfer builder test asserts TRANSACTION_DEFAULT_EXPIRATION equals 10800000 (3 hours)
  • Verify token transfer transactions built without explicit expiration default to ~3 hours from now
  • Run sdk-coin-trx unit tests

TICKET: COIN-7612

🤖 Generated with Claude Code

Change TRANSACTION_DEFAULT_EXPIRATION from 1 hour (3600000ms) to 3 hours
(10800000ms) for all TRX transaction types including token transfers.
Add test to verify token transfers use the 3-hour default expiration.

TICKET: COIN-7612

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Vijay-Jagannathan Vijay-Jagannathan marked this pull request as ready for review March 3, 2026 12:15
@Vijay-Jagannathan Vijay-Jagannathan requested a review from a team as a code owner March 3, 2026 12:15
Copy link
Contributor

@HimanshuS2212 HimanshuS2212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vijay-Jagannathan Vijay-Jagannathan merged commit 6e6783f into master Mar 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants