Add label argument to createChan API endpoint#2104
Open
813492291816 wants to merge 1 commit intoBitmessage:v0.6from
Open
Add label argument to createChan API endpoint#2104813492291816 wants to merge 1 commit intoBitmessage:v0.6from
813492291816 wants to merge 1 commit intoBitmessage:v0.6from
Conversation
Member
|
I think this should be fixed differently. |
Contributor
Author
|
I don't know if this is an issue with jsonrpclib or bitmessage, or even how to debug it, but with regard to this PR, I see utility for a number of use cases in allowing the user to set the label of a new chan at creation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonrpclib throws errors sometimes due to the auto-generated labels that are based on the passphrases I set. Example:
(-32603, '<class 'api.APIError'>:API Error 0021: Unexpected API Failure - bad interpolation variable reference '%(793569%(4"]'')This "%(793569%(4"]" is a substring of my label that's based on the passphrase and the error prevents any data from being received.
Because the passphrases I use are generated in a specific way, I can't just exclude certain character combinations as possibilities. Therefore, I propose adding the ability to set the label at the time of the chan creation, which will allow me to set the label to something different/safer than the passphrase.