Fix Waveshare S3 home fingerprint#274
Open
oroderico wants to merge 2 commits intoBlockstream:masterfrom
Open
Conversation
Collaborator
|
Hi, I think the problem of titles being too wide for screens in given orientations should be considered a generic one, and so fixed generically rather than on a per-screen and/or per-device basis, even if this needs to be opted into with a flag. |
Contributor
Author
|
I can fix this, but I did it this way because I didn't have other boards to test the behavior of the fix. Can I adjust the code? |
Contributor
|
This was discussed before here, implemented as scrolling when the name doesn't fit, but ultimately discarded before merging the Waveshare stuff into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
On Waveshare ESP32-S3 LCD Touch (portrait), the Home screen header has less
horizontal space than landscape boards. The default title uses the full
device_namestring (e.g.Jade <short-id>), which can be clipped on theportrait header.
The device identifier itself is correct; only the rendering is affected.
Fix
For Waveshare S3 only (
CONFIG_BOARD_TYPE_WS_TOUCH_LCD2), adjust the Homescreen activity title:
Jadeprefix, the UI uses onlythe suffix portion (skipping the
Jadeprefix) as the title.Implementation Notes
to
gui_make_activity_ex().