Conversation
|
|
bethac07
left a comment
There was a problem hiding this comment.
Awesome! A couple tiny comments around print statements, hardcoding of Windows-style paths, and subprocess nuance, but otherwise, works great!
bethac07
left a comment
There was a problem hiding this comment.
I approve on the code basis, but someone else (@ErinWeisbart ?) should check if anything else is needed on our list of things we ask for in a submission now
|
Does this work with the citation generator? |
Yes, it works with the citation generator. Documentation added. Just added a page for RunDeepProfiler as well so we can edit instructions as we change stuff. |
|
@fefossa The install instructions you added don't match the strategy we describe in https://github.com/CellProfiler/CellProfiler-plugins/blob/master/documentation/CP-plugins-documentation/using_plugins.md Does it not work to use the setup.py-based strategy that Callum has set up? If not, we need to add a description to the using_plugins page telling people to follow alternative instructions for RunDeepProfiler. If it does, can you add the dependencies to |
We can use setup.py yes (I'll push that), but there's a git clone and pip install for DeepProfiler itself before doing the setup.py in CP-plugins; do we think these instructions can go inside using_plugins as a note? @ErinWeisbart |
|
@ErinWeisbart instructions are updated! |
Option to add the measurements to the exporttospreadsheet/database and display those measurements on the window
|
Now I've added the option to export the results into a CellProfiler format (within the CSVs). Because I'm on Windows I still cannot test on analysis mode if the files are being written to the spreadsheet, but I can see on the display window below that the way I'm getting the measurements looks correct. If you could test on Mac @bethac07 thank you! |
|
Actually, @ErinWeisbart, do you have a non-M1 mac? |
|
I do have a non-M1 Mac. I can test this later today. Stay tuned... |

No description provided.