Open
Conversation
Now, I have to create the for loop function. I deleted of commented all parts having to do with other measurements (including per image measurements) and also removed if statements, assuming here wants_obects is always True and perform_RWC is always True
in order to escape import errors in CP (name of file must be all lower case) and debugger cache (Nodar had to change the actual name bc the previous capitalized one remained cached)
bethac07
reviewed
Aug 28, 2024
bethac07
reviewed
Aug 28, 2024
| M_PER_OBJECT = "Within each object individually" | ||
|
|
||
| """Feature name format for the RWC Coefficient measurement""" | ||
| F_RWC_FORMAT = "Correlation_RWC_%s_%s" |
Member
There was a problem hiding this comment.
This may cause a collision if the person has also measured RWC regularly, can we name it something different?
bethac07
reviewed
Aug 28, 2024
| return True | ||
|
|
||
|
|
||
| def get_scale(scale_1, scale_2): |
bethac07
reviewed
Aug 28, 2024
| ################################# | ||
|
|
||
| import centrosome.cpmorphology | ||
| import centrosome.zernike |
Member
There was a problem hiding this comment.
Make sure to remove the ones you don't. need
bethac07
reviewed
Aug 28, 2024
| @@ -0,0 +1,28 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
Can you remove this file from the commit, please?
bethac07
requested changes
Aug 28, 2024
Member
bethac07
left a comment
bethac07
left a comment
There was a problem hiding this comment.
Awesome job! Just some cleanup to do, plus add to the documentation
looks on its way but i messed too much with the code before, might have to restart fresh
still have to check that the values make sense
add comments clarifying R_perObj and Di_perObj
Need to check why Correlation_RWCperObj_V5_ER gives inf values and values way above 1!
measure absolute and relative (vs the pixels of the object) above-threshold (both thresholds) pixels
I changed thresholding to be >= instead of >, bc otherwise, pixels of value 0 get automatically excluded no matter the threshold
…hold as greater only
Member
|
@emiglietta Can you remove the extra file and do some cleaning of unneeded commented text, when you have a sec, so we can merge? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.