Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singularity Support
Add Singularity support. All test pass, all arenas run with dummy agents, the Docker path remains almost unchanged. It would be great to test with some actual API calls.
Core changes
SingularityEnvironmentsupport toenvironment.py.pvp.py("file changed" warning can happen on weka with Singularity).README.mdto mention Singularity as an alternative to Docker.Arena-specific fixes
Singularity's
--cleanenvclears environment variables set during%post, breaking tools that rely on$HOME.RUSTUP_HOME=/root/.rustupandCARGO_HOME=/root/.cargoin%environment.GRADLE_USER_HOME=/root/.gradlein%environment.Singularity's
--containflag clears /tmp and /home after eachexecute()invocation.dwarf.redfrom /home to /opt (both in .def and .py).git configinstead of global (which writes to~/.gitconfig).SingularityEnvironment.execute()captures stderr and stdout together, polluting command output.git rev-parse HEADoutput.git diff tag1..tag2never produces a prelude).Singularity's background processes don't persist across
execute()calls.subprocess.Popento start player HTTP servers.Singularity sandbox directories can contain symlinks that don't resolve on the host.
symlinks=Truetoshutil.copytreeincopy_between_containers.Test fixes
/home/dwarf.redto/opt/dwarf.red.