mctpd: Update interface vtables when we change to BusOwner role#138
Draft
jk-ozlabs wants to merge 1 commit intoCodeConstruct:mainfrom
Draft
mctpd: Update interface vtables when we change to BusOwner role#138jk-ozlabs wants to merge 1 commit intoCodeConstruct:mainfrom
jk-ozlabs wants to merge 1 commit intoCodeConstruct:mainfrom
Conversation
Currently, setting an interface's Role property only sets the link->role. However, we also want to expose the BusOwner1 interface when changing from Unknown to BusOwner, so register the bus_link_owner_vtable on the interface object when this happens. dbus does not like the vtables changing during a call, so we defer this to the main loop context. Fixes: CodeConstruct#130 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
jk-ozlabs
force-pushed
the
dev/role-set
branch
from
d2bb974 to
99e42aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, setting an interface's Role property only sets the link->role.
However, we also want to expose the BusOwner1 interface when changing from Unknown to BusOwner, so register the bus_link_owner_vtable on the interface object when this happens.
dbus does not like the vtables changing during a call, so we defer this to the main loop context.
Fixes: #130