Pass the id of the DOM element rather than the element itself#70
Open
matteoraf wants to merge 9 commits intoCodeYellowBV:masterfrom
Open
Pass the id of the DOM element rather than the element itself#70matteoraf wants to merge 9 commits intoCodeYellowBV:masterfrom
matteoraf wants to merge 9 commits intoCodeYellowBV:masterfrom
Conversation
… than the element itself and let the plugin look for the elmement in document. This way you can use the plugin even when you need to pass options before the DOM is rendered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I needed to use this plugin with a Vue.js project and I needed to append the legend to a DOM element which wasn't yet rendered at the time the plugin was loaded, I needed to be able to pass the id of the element and leave the trouble of retrieving the DOM element to the plugin itself.